Fix self statement semicolon rewrite#1347
Open
Pieter12345 wants to merge 1 commit intoEngineHub:masterfrom
Open
Fix self statement semicolon rewrite#1347Pieter12345 wants to merge 1 commit intoEngineHub:masterfrom
Pieter12345 wants to merge 1 commit intoEngineHub:masterfrom
Conversation
Fix semicolons not getting added to self statements where placement was intended.
Pieter12345
force-pushed
the
self-statement-rewrite-fix
branch
from
fd582aa to
5959901
Compare
Member
|
Intended behavior is that switch with inner statements is also a statement. Same for ifelse. It's odd that the outer one isn't a self-statement as well, I suppose it's likely because of the order of operations in the tree descent? Anyways, I would expect the outer switch/if to be in a statement as well, but the fact that the inner ones are statements is expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this fixes the intended behavior of the
addSelfStatementsmethod, two unit tests are broken since this newly added__autoconcat__ends up in the runtime AST as__statements__:@LadyCailin What is the intended behavior here?